question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Generic Refactoring

See original GitHub issue

Current Behaviour:

Some code is not readable and some optimization should be applied. For example:

  • URL formatting should be using: str.format(): '{}/{}/{}'.format(..., ..., ...) or better f'{domain}/{path}/{id}'
  • issue #301
  • please @chrizandr @xadahiya add to the list
  • Adding doc strings wherever missing

Expected Behaviour:

Code should be refactored

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Reactions:5
  • Comments:13 (12 by maintainers)

github_iconTop GitHub Comments

2reactions
xadahiyacommented, Dec 30, 2018

I don’t think there’s any nice way to use fstrings in python 3.5 right now. If we want to use fstrings then we might have to ditch python 3.5, not sure we should do that. If think it would be better if we stick we old string formatting, for now at least.

1reaction
de-shcommented, Jan 12, 2019

Hey @harsheetkakar, there’s no need to ask. If you have any suggestions for changes and refactoring work, first read the Starting Material and open a PR to make your changes!

Read more comments on GitHub >

github_iconTop Results From Across the Web

Generic Refactoring for Generic Parallelism in C++
We define a refactoring that converts a C++ loop into a GrPPI pipeline pattern, containing one or more stages that are executed concurrently...
Read more >
Convert Raw Types to Generics refactoring - JetBrains
The Convert Raw Types to Generics refactoring is designed to transform existing code that does not use Generics, into the Generics-aware ...
Read more >
Generic Refactoring for Generic Parallelism in C++
This paper describes software refactorings to semi-automatically introduce instances of GrPPI patterns into sequential C++ code, as well as ...
Read more >
Refactoring GrPPI : generic refactoring for generic parallelism in C++
This paper describes software refactorings to semi-automatically introduce instances of GrPPI patterns into sequential C++ code, as well as safety checking ...
Read more >
Towards Generic Refactoring - CiteSeerX
We define a challenging and meaningful benchmark for generic- ity in language processing, namely the notion of generic program refactoring.
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found