question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

IRI missing domain name

See original GitHub issue

I’m submitting a

  • [ x] bug report.
  • feature request.

Current Behaviour:

Every IRI in the API should be a complete IRI to be dereferenced. For example:

{
  "@context": "/serverapi/contexts/DatastreamCollection.jsonld",
  "@id": "/serverapi/DatastreamCollection/",
  "@type": "DatastreamCollection",
  "hydra:totalItems": 0,
  "hydra:view": {
     "@id": "/serverapi/DatastreamCollection?page=1",
    "@type": "hydra:PartialCollectionView",
    "hydra:first": "/serverapi/DatastreamCollection?page=1",
    "hydra:last": "/serverapi/DatastreamCollection?page=1"
},
...

All paths starting with /... should start with http://localhost:8000/... so that the link can be followed by clicking/reading/dereferencing the string.

Expected Behaviour:

{
  "@context": "http://localhost:8000/serverapi/contexts/DatastreamCollection.jsonld",
  "@id": "http://localhost:8000/serverapi/DatastreamCollection/",
  "@type": "DatastreamCollection",
  "hydra:totalItems": 0,
  "hydra:view": {
     "@id": "http://localhost:8000/serverapi/DatastreamCollection?page=1",
    "@type": "hydra:PartialCollectionView",
    "hydra:first": "http://localhost:8000/serverapi/DatastreamCollection?page=1",
    "hydra:last": "http://localhost:8000/serverapi/DatastreamCollection?page=1"
},
...

Having a HOST_DOMAIN global variable that has default to http://localhost:port would be fine.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:11 (8 by maintainers)

github_iconTop GitHub Comments

1reaction
farazkhanfk7commented, Jan 29, 2021

@priyanshunayan Thanks for catching that. Looks like I missed the part where we I had to add host name in crud.py as well. I’ll submit a PR with new changes.

0reactions
khabdrickcommented, Feb 20, 2021

This issue is showing open, is it actually open @Mec-iS

Read more comments on GitHub >

github_iconTop Results From Across the Web

getNeigbors 'domain' attribute should contain IP if empty · Issue ...
The domain field is missing completely, causing confusing output in tools like Iota peer manager. As soon as the domain name is not...
Read more >
Nielsen, IRI and SPINS: Navigating The CPG Data Syndicators
Unlike NielsenIQ and IRI, SPINS is focused mainly on the health and ... CPG manufacturers have no shortage of options to choose from....
Read more >
Re: Restrictions on domain names for Top Level Domains (TLDs) for ...
While it's interesting, it doesn't seem to add or remove any restrictions on what a > "legal" IRI is, or how to process...
Read more >
About Us - IRI
Are you missing key innovation or category opportunities? ... The future of CPG is about bringing a custom marketing strategy to each consumer...
Read more >
Buying Nielsen/IRI/SPINS Reports? Avoid These Three ...
1 Ordering data on “Category X”, only to find key items missing. ... coded at all and now is the time to find...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found