Refactor deeply nested if blocks

I’m submitting a

• bug report.
• feature request.

Current Behaviour:

Currently the code in resources.py has deeply nested if blocks which decrease the readability of the code, also it causes the code to violate PEP max-line-length constraint, trying to avoid that we use line breaks which makes the code even less readable.

Expected Behaviour:

Instead of using nested Ifs we should check every condition separately and return an appropriate response for that. Ex.

if condition_1:
     if condition_2:
              if condition_3:
                    do_something
              else:
                    response for violation of condition_3
     else
           response for violation of conditon_2
else:
       response for violation of condition_1

should become

if(!condition_1):
     handle_it
elif(!conditio_2):
     handle_it
elif(!condtion_3):
     handle_it
else:
      do_something

So to summarize instead of checking for conditions to be true we should check for false and handle it immediately.

Steps to reproduce:

Do you want to work on this issue?

No

[chrizandr]

Is there any OO pattern we can apply, like Observer on a property or something similar?

I’ll look into this and maybe see how we can change it. For now, I think shifting to the negative conditions to reduce the nesting would not be of much benefit, since code complexity would still remain the same, if not more.

Maybe remove the begginer tags, since one would need a deeper understanding of how Hydrus is handling things in order to refactor this and we might also have to use app context objects to group these conditions into functions.

[kartikpandey596]

You can use flag to solve this problem. For example: Your present condition is:

If (condition):
     If (condition):
          ....
     else:
else:
    ...

The solution is:

If(condition):
     If(condition):
           ....   Before reaching the max situation pass check variable value to 1 when if condition is true
Otherwise its default value is 0
    else:
else:
    ...

And at last Check the condition

If(check==1):
    If(condition):
         .. Again continue the condition
    else:
else:
    ...```
In this way you solve this problem