Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Disconnect error not detected

See original GitHub issue

Current disconnect handling implementation in ChannelHead relies on matching IOException.getMessage. This is problematic - for example, on Windows these messages are localized, which leads to junk log messages:

2019-05-31 10:35:21,048  WARN: Channel IOException not known to be a disconnect error //[Thread-12] o.h.blaze.channel.nio2.ByteBufferHead.checkError() L:18
java.io.IOException: Удаленный хост принудительно разорвал существующее подключение

Shouldn’t there be a better way to detect such situations? What do other libraries do?

Issue Analytics

State:
Created 4 years ago
Reactions:3
Comments:10 (5 by maintainers)

Top GitHub Comments

2reactions

rossabakercommented, Jun 10, 2019

This is way better than we do, but still not great: https://github.com/netty/netty/blob/f17bfd0f64189d91302fbdd15103788bf9eabaa2/handler/src/main/java/io/netty/handler/ssl/SslHandler.java#L1100

0reactions

rossabakercommented, Aug 6, 2021

The EOF is a regrettable design, because it’s both a command an an exception. It suppresses the stack trace because the exception is used for control flow and is expected to happen a lot.

We might be able to enhance the request loop in BlazeClient to wrap the EOF in an exception that provides request context. 🤔