Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Graal: remove reflective header parsers

See original GitHub issue

Based on @noelwelsh’s fine work, this commit shows a problem with modeled headers:

$ curl http://localhost:8080/raw
Some(Accept: */*)
$ curl http://localhost:8080/model
None

It works on the JVM:

$ curl http://localhost:8080/raw
Some(Accept: */*)
$ curl http://localhost:8080/model
Some(Accept: */*)

This is almost certainly a result of bootstrapping the header parsers with runtime reflection. It’s been a hidden implementation detail for years, but fails in the world beyond the JVM.

Issue Analytics

State:
Created 4 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

1reaction

jopricecommented, Apr 3, 2020

I spoke too soon. I have a completely different issue that looked similar to this one: An Authorization header with a single token, that is, not containing the “type” specifier. The compliant parser of http4s doesn’t let that one slide. Please excuse the noise!

0reactions

rossabakercommented, Apr 3, 2020

This is a common pitfall. Maybe we should consider a version that returns either the raw header or the modeled header so things don’t just “disappear” like this.