It's not possible to unit test a WebSocket application

Hi, I’m migrating my Http4s WebSocket application from 1.0.0-M23 to 1.0.0-M34.

Now, as I shouldn’t create a WebSocketBuilder myself, but it is provided by the server, how can I unit test my routes if they require passing a WebSocketBuilder which I can’t create myself?

[armanbilge]

Making a method public or adding a method is binary compatible. We can take this in 0.23 😃

[gvolpe]

IIUC the main idea behind creating a WebSocketBuilder internally is that it should have the same lifecycle as the HTTP server.

However, as long as the HTTP server builder doesn’t allow the users to use a custom instance, it should be fine to make the constructors public. For example, the current Ember builder takes a function:

def withHttpWebSocketApp(f: WebSocketBuilder2[F] => HttpApp[F]): EmberServerBuilder[F] = ???

If this is the only way to use a WebSocketBuilder and build a WebSocket application, I’d say it doesn’t make sense to hide the constructors from the users, and it will facilitate unit-testing where a server is not involved.

Am I missing some other reason why these constructors have been made private?