How to gracefully shutdown the server? (tests are failing)

I write some tests and I cannot get the proxy gracefully shutdown.

My test is very simple:

it('should start the server', async () => {
  const server = await proxy(8000);
  await delay(1000);
  await server.stop();
});

where proxy() is an async function having this:

  await server.start(port);
  return server;

Now when I run my tests as $ npm run test -- -t 'should start the server' --detectOpenHandles I get this:

Jest has detected the following 1 open handle potentially keeping Jest from exiting:

  ●  JSSTREAM

      1 | import fs from 'fs';
      2 | import { basename, join, resolve } from 'path';
    > 3 | import { getLocal, generateCACertificate, generateSPKIFingerprint, RequestRuleBuilder } from 'mockttp';
        | ^
      4 |
      5 | import { ResolvedManifest } from './model';
      6 | import { fileExists, ManifestError, readFile, readManifest, saveFile } from './service';

      at Object.<anonymous> (node_modules/http2-wrapper/source/utils/js-stream-socket.js:6:25)
      at Object.<anonymous> (node_modules/http2-wrapper/source/proxies/h1-over-h2.js:3:24)
      at Object.<anonymous> (node_modules/http2-wrapper/source/index.js:13:5)
      at Object.<anonymous> (node_modules/mockttp/src/rules/requests/request-handlers.ts:8:1)
      at Object.<anonymous> (node_modules/mockttp/src/rules/requests/request-rule.ts:10:1)
      at Object.<anonymous> (node_modules/mockttp/src/server/mockttp-server.ts:28:1)
      at Object.<anonymous> (node_modules/mockttp/src/main.ts:2:1)
      at Object.<anonymous> (src/proxy.ts:3:1)
      at Object.<anonymous> (src/proxy.test.ts:1:1)

What can I do about this?

P.S. Here is my proxy code: https://github.com/OnkelTem/wmod-proxy/blob/master/src/proxy.ts just for reference.

[pimterry]

That’s surprising. It sounds like this is caused by some HTTP/2 connection that’s staying open. HTTP/2 support is a bit experimental in places, and I can definitely believe that there’s some cases where pooled connections aren’t shut down as aggressively as intended. I’d definitely like to tighten up this kind of thing though.

That said, it’s a bit unusual that HTTP/2 is being used here at all. Because it’s experimental, Mockttp uses ALPN to actively avoid it where possible - by default it’s only used for clients who connect and say they only support HTTP/2, not HTTP/1 (those exist, notably in clients using gRPC, but it’s not common). One quick fix option might be to just disable HTTP/2 - you can do that by passing a http2: false option to getLocal() (docs). Is HTTP/2 important for your setup?

[pmpak]

I was trying quite a lot to make this error go away until I stumbled upon this issue. Setting {http2: false} worked like a charm. thanks a lot !