Listener middleware not called for catchAll listener

Version

• hubot@2.19.0

Problem

Hubot supports populating contents in message object through middlewares, but it seems the contents are lost in catchAll handler.

Reproduce Steps

scripts/example.coffee:

# Description:
#   Test listener and catchAll.
# 
module.exports = (robot) ->
  robot.catchAll (res) ->
    res.reply res.message.secret
  robot.respond /test/, (res) ->
    res.reply res.message.secret
  robot.listenerMiddleware (context, next, done) ->
    context.response.message.secret = 'hello'
    next()

Testing

C:\Users\rophy\git\hubot-secret>bin\hubot
up to date in 1.074s
hubot-secret> hubot-secret test
hubot-secret> Shell: hello
hubot-secret> hubot-secret abcabc
hubot-secret> Shell: undefined

[timkinnane]

Good stuff. Well this tickets original question is answered, but if we’re keeping it open to resolve the bug it’s raised, can we modify the title to something like “Listener middleware not called for catchAll listener”?

[timkinnane]

OK actually I think I know why this isn’t working anyway. From the docs: “Listener middleware inserts logic between the listener matching a message and the listener executing” - catch all fires when no listeners match, so the listener middleware would never be called in this case. You should try it with robot.receiveMiddleware instead.