question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

PNDMSchedulerTest::test_full_loop_no_noise uses time index rather than time_step in `step`

See original GitHub issue

Describe the bug

One can see the usage of the PNDMScheduler in the PNDMPipeline (Or stable diffusion for that matter), and it looks like this, with timesteps passed into the scheduler

https://github.com/huggingface/diffusers/blob/f4781a0b27ffb3ea61ecd25b0b87305e0960304e/src/diffusers/pipelines/pndm/pipeline_pndm.py#L97-L101

Though, in the test_scheduler file it is backwards. This may cause some unintended behavior going forward.

https://github.com/huggingface/diffusers/blob/f4781a0b27ffb3ea61ecd25b0b87305e0960304e/tests/test_scheduler.py#L633-L655

Reproduction

No response

Logs

No response

System Info

Not a runtime bug.

Issue Analytics

  • State:closed
  • Created a year ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
patrickvonplatencommented, Sep 17, 2022

Waiting here until the schedulers are all in PyTorch / Numpy respectively at which point we have to update the tests anyway

0reactions
patrickvonplatencommented, Dec 20, 2022

This can be closed by now as PNDM is fixed I believe 😃

Read more comments on GitHub >

github_iconTop Results From Across the Web

Controlling the Time Dependent solver timesteps - COMSOL
To find out if a fixed timestep is being used, go to the Time-Dependent Solver settings, Time Stepping section. There, you will see...
Read more >
Simulation with time step greater than 0.025 ms
Hi, I try to simulate some biological neurons models with parameters provided by Allen institute. When i fixe time step to 0.05 ms, ......
Read more >
How time stepping works—ArcGIS Pro | Documentation
Using time steps. Time steps slice your input data for analysis into steps defined by three parameters (time step interval, time step repeat...
Read more >
SMS:Error vs. Time Step Plot - XMS Wiki
An Error vs. Time Step plot is used with transient simulations to display the mean error, mean absolute error, and root mean squared...
Read more >
Finding skipped index time steps and filling the values in a ...
I am working with a pandas DataFrame that has an index that skips one or more time steps which in ...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found