Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Rename variables from single letter to better naming

See original GitHub issue

Pretty much all code in https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py still corresponds to the copy-pasted version from the beginning.

While weight names shouldn’t be renamed, we should rename all single letter variables to more explicit variable naming. E.g. h -> hidden_states.

Single letter variables are hard to deal with as search and replace doesn’t work on them and are hard to read

Issue Analytics

State:
Created a year ago
Reactions:1
Comments:19 (19 by maintainers)

Top GitHub Comments

3reactions

rashmimarganiatgithubcommented, Sep 9, 2022

@daspartho ,q, k, v can be replaced with query,key,value. b, c, h, w can be replaced with batch,channel,height,weight .

2reactions

patil-surajcommented, Sep 29, 2022

Hey @i-am-epic @daspartho , there are still some places with single letter variables in resenet.py , feel free to work on those! I’m listing them down here.

https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py#L37 https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py#L54 https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py#L177 https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py#L239 https://github.com/huggingface/diffusers/blob/main/src/diffusers/models/resnet.py#L329