For HTTP request errors, add response to exception message

Is your feature request related to a problem? Please describe.

Most of the time, hf.co sends a JSON response along with HTTP error codes. But it’s not shown in the stack trace:

requests.exceptions.HTTPError: 404 Client Error: Not Found for url: http://localhost:5564/api/repos/delete

Which leads hf.co to send a 409 here even though it’s really not the correct HTTP code (see https://github.com/huggingface/moon-landing/issues/2272)

Describe the solution you’d like Add the error message from hf.co when available.

I tried this in HfApi.delete_repo:

       try:
            r.raise_for_status()
        except requests.exceptions.RequestException as e:
            message = e.response.json()["error"]
            import sys
            raise type(e)(str(e) + " - " + message).with_traceback(sys.exc_info()[2])

This seems to work, but I suck very much at Python and it’s a handful of lines. (and would cause an unrelated error when response.json() fails)

cc @SBrandeis @osanseviero @LysandreJik

[severo]

This loses the full stack trace I think

from e ensures the stack trace is not cut.

https://docs.python.org/3/tutorial/errors.html#exception-chaining

[coyotte508]

The staging backend was updated 😃 (it was long overdue!)

There were a few errors in the curl command, with this it should work:

curl -X DELETE -H "Authorization: Bearer ---token---" -d "{'name': 'repo-does-not-exist'}" https://huggingface.co/api/repos/delete   

But I do get a JSON response 🤔 :

{"error":"Conflict"}

Maybe if the message isn’t JSON just send the original error? (or the plain text message)

And yes it would be fine, thank you 😃 We will update the message with the status code on our side afterwards.