question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

should mBART-large-en-ro have decoder_start_token_id by default?

See original GitHub issue

Hypothesis: since the argument prepend_bos is set to “False” in fairseq/examples/README.md, mbart-large-en-ro does not need decoder_start_token_id.

TODO:

  • create branch that deletes decoder_start_token_id. Setting it to None in the config might not be enough.
  • verify that decoder_start_token_id is in fact not being used by setting a breakpoint in generate.
  • run_eval.py on wmt-en-ro/test and see if BLEU is >= 26.46, the score with decoder_start_token_id=250020.

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Reactions:1
  • Comments:7 (7 by maintainers)

github_iconTop GitHub Comments

1reaction
sshleifercommented, Aug 22, 2020

Gunna close this since the score is now basically the same as fairseq. Thanks for your help!

0reactions
sshleifercommented, Sep 28, 2020

I think I fixed this another way in #6526 on master

python run_eval.py facebook/mbart-large-en-ro $ENRO_DIR/test.source eos_baseline_enro_test_generations.txt \
--reference_path $ENRO_DIR/test.target \
--score_path baseline_test_bleu_eos.json --bs 32 --task translation --fp16

=> {‘bleu’: 26.81}

python run_eval.py facebook/mbart-large-en-ro $ENRO_DIR/test.source \
eos_baseline_enro_test_generations.txt --reference_path $ENRO_DIR/test.target \
--score_path baseline_test_bleu_eos.json --bs 32 --task translation --fp16  \
--decoder_start_token_id 2

{‘bleu’: 11.57} (and takes 40 mins!)

in the original fairseq I get 26.83.

Read more comments on GitHub >

github_iconTop Results From Across the Web

No results found

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found