question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

The configuration of 3.0.2 and 3.1.0 is not compatible

See original GitHub issue

The configuration of 3.0.2 and 3.1.0 is not compatible.

For example, in https://github.com/huggingface/transformers/blob/master/src/transformers/modeling_bert.py#L388, config.chunk_size_feed_forward should change to config.get('chunk_size_feed_forward', 0), because there is not chunk_size_feed_forward config in former version.

class BertLayer(nn.Module):
    def __init__(self, config):
        super().__init__()
        # self.chunk_size_feed_forward = config.chunk_size_feed_forward
        self.chunk_size_feed_forward = config.get('chunk_size_feed_forward', 0)
        self.seq_len_dim = 1
        self.attention = BertAttention(config)
        self.is_decoder = config.is_decoder
        self.add_cross_attention = config.add_cross_attention
        if self.add_cross_attention:
            assert self.is_decoder, f"{self} should be used as a decoder model if cross attention is added"
            self.crossattention = BertAttention(config)
        self.intermediate = BertIntermediate(config)
        self.output = BertOutput(config)

Issue Analytics

  • State:closed
  • Created 3 years ago
  • Comments:5 (1 by maintainers)

github_iconTop GitHub Comments

1reaction
patrickvonplatencommented, Sep 7, 2020

I see what you mean! From 3.1.0 onwards every configuration has a config.chunk_size_feed_forward parameter. So as far as I can see whenever a config is loaded (whether via .from_pretrained() or with BertConfig(....), this parameter is part of the config…). Can you give me an example where this would not be the case?

0reactions
franciszzjcommented, Sep 8, 2020

@patrickvonplaten In the future, I will make more normative to call modules. Thanks for your replay. I close this issue.

Read more comments on GitHub >

github_iconTop Results From Across the Web

Minimum supported Gradle version is 3.3. Current version is ...
Solution: When we open gradle-wrapper.properties file in IDE it shows correct distributionUrl. but originally it has not been updated. So change ...
Read more >
Migrating from 2.x to 3.0 - Socket.IO
Below are listed the non backward-compatible changes. io.set() is removed​. This method was deprecated in the 1.0 release and kept for backward- ...
Read more >
NuGet Warning NU1605 - Microsoft Learn
NET Core 1.0 and 1.1 are not compatible with each other when they are referenced together in a .NET Core 3.0 or higher...
Read more >
Release notes — AndroidAPS 3.0 documentation
Configuration /Configuration/Watchfaces.htmll#wear-os-tiles> , translations @Andries-Smit; Wear code refactored. Not backward compatible anymore @MilosKozak ...
Read more >
Release Notes - Spaces - Confluence - Atlassian
This version also introduces changes to the supported platforms and to the ... Additional changes have been appllied to the default configuration (NOT...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found