Must use different character for nsSeparator and keySeparator

Using the same character for nsSeparator and keySeparator ('.') fails to translate keys within objects.

clients.json (CLIENTS namespace):

{
    "MAINTENANCE": {
        "DELETE_PROMPT": "Are you sure you want to delete this client?"
    }
}

i18next.t('CLIENTS.MAINTENANCE.DELETE_PROMPT') // nope!

Changing the namespace separator to ':' works as expected.

i18next.t('CLIENTS:MAINTENANCE.DELETE_PROMPT') // yaas!

Ideally you should be able to use the same character to separate the namespace from key paths, but if not, at the very least the documentation should make it very clear this is not an option. 😃

[jamuhl]

argh…always the index 😉…just published i18next@6.1.2 fixing it - and added some tests for this feature.

There is no documentation for contribution. npm i to install build dependencies. npm test is all that should be done before submitting a PR. The PR will run through travis CI and coveralls anyway, so failing tests would show up in the PR anyway.

[codeandcats]

Hi Jamuhl,

Thanks for adding that change, I’ve had some time to test it this morning and although it worked for most translations, I noticed one of my namespaces, whichever namespace is first in the config, would consistently not get translated.

I narrowed it down to this line of code:

if (nsSeparator !== keySeparator || nsSeparator === keySeparator && this.options.ns.indexOf(parts[0])) namespaces = parts.shift();

I believe should be:

if (nsSeparator !== keySeparator || nsSeparator === keySeparator && this.options.ns.indexOf(parts[0]) > -1) namespaces = parts.shift();

I can submit a PR if you like, I’m just curious (for this and any future contributions) if you have any doco for contributing, e.g. install + build steps, conventions, etc.