Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

customParseFormat doesn't work when format doesn't fit the Date

See original GitHub issue

dayjs('2019/04/19, 'MMDDYY').isValid() returns true and it parses to Wed Jul 20 2005.

Moment.js does not parse it.

https://jsfiddle.net/3meh8g0k/

You can get the same results using other different formats (e.g dayjs('2019/04/19, ‘MM’ returns Mon May 20 2019)

IssueHunt Summary

iamkun has been rewarded.

Backers (Total: $100.00)

issuehunt ($100.00)

Submitted pull Requests

#866 Consider using Intl api and update customParseFormat

Tips

Checkout the Issuehunt explorer to discover more funded issues.
Need some help from other developers? Add your repositories on IssueHunt to raise funds.

IssueHunt has been backed by the following sponsors. Become a sponsor

Issue Analytics

State:
Created 4 years ago
Reactions:3
Comments:12 (4 by maintainers)

Top GitHub Comments

6reactions

mireflycommented, Jun 4, 2019

@iamkun Thanks, but I feel I might have confused you… I am not proposing to ignore separator tokens, but to require exact matching between input string and format.

 dayjs('2019/04/19, 'YYYYMMDD') ---> invalid
 dayjs('2019/04/19, 'YYYY/MM/DD') ---> 2019/04/19
 dayjs('2019/04/19ab, 'YYYY/MM/DD') ---> invalid, not allowing characters left after parsing

4reactions

huytdcommented, Sep 17, 2019

@iamkun I think what @mirefly proposing is a good approach. Is there any concern you have?

I’d like to chime in and try implement it 😃