Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Date validity check does not work correctly

See original GitHub issue

Describe the bug I tried to parse 2020-13-13 with this library and its isValid() check returned true while I expected it to return false

Expected behavior I expected the date is valid check to return false

Information

Day.js Version [1.8.34]
OS: [iOS]
Browser [Node]
Time zone: [e.g. GMT+03:00 EAT (East African Time)]

Issue Analytics

State:
Created 3 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

iamkuncommented, Aug 25, 2020

You may specify a boolean for the last argument to use strict parsing. Strict parsing requires that the format and input match exactly, including delimiters.

dayjs('1970-00-00', 'YYYY-MM-DD').isValid() // true
dayjs('1970-00-00', 'YYYY-MM-DD', true).isValid() // false
dayjs('1970-00-00', 'YYYY-MM-DD', 'es', true).isValid() // false

https://day.js.org/docs/en/parse/string-format

0reactions

iamkuncommented, Sep 24, 2020

Cool! I’ll close this issue since it’s been solved. Feel free to reopen if you have updates on this