Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

expect(dayjs('2019-07-28').week()).toBe(30)

See original GitHub issue

Describe the bug Since the introduction of locale.weekStart I expect it to work with e.g .week() plugin, but currently it doesn’t. 2019-07-28 is Sunday, so in en-gb locale it should be part of week 30, not week 31.

In Jest syntax:

require('dayjs/locale/en-gb')
dayjs.locale('en-gb')

expect(dayjs('2019-07-28').week()).toBe(30)

throws:

Expected: 30
Received: 31

Information

Day.js Version: 1.8.15
OS: MacOS
Browser Chrome 76
Time zone: Stockholm

UPD: attaching a screenshot of my WeekNumberAware calendar:

Issue Analytics

State:
Created 4 years ago
Reactions:1
Comments:14 (6 by maintainers)

Top GitHub Comments

3reactions

g1eny0ungcommented, Aug 8, 2019

I will be working on this. Thanks for finding this problem.

1reaction

kirillgroshkovcommented, Aug 13, 2019

Also, for proper testing - loop over few years of days and compare momentjs and dayjs. There are edge cases around year start that I didn’t manage to fix.

Example of how I tested it: https://github.com/NaturalCycles/time-lib/blob/master/src/plugin/weekOfYear.test.ts