Help migrating from momentjs to dayjs (using startOf/endOf/add/substract)

Hello, I’m unable to migrate my momentjs code to dayjs.

The job of my code is to have a timeframe depending of a cohort (for a line chart).

import moment from 'moment';
import dayjs from 'dayjs';

/* MOMENTJS CODE */

export const getFromDate = (cohort, subAmount = 0) => {
  switch (cohort) {
    case 'hours': return moment().startOf('hour').subtract(subAmount, 'hours');
    case 'days': return moment().startOf('day').subtract(subAmount, 'days');
    case 'weeks': return moment().startOf('isoWeek').subtract(subAmount, 'weeks');
    case 'months': return moment().startOf('month').subtract(subAmount, 'months');
    case 'years': return moment().startOf('year').subtract(subAmount, 'years');
    default: return null;
  }
};

export const getToDate = (cohort, addAmount = 0) => {
  switch (cohort) {
    case 'hours': return moment().endOf('hour').add(addAmount, 'hours');
    case 'days': return moment().endOf('day').add(addAmount, 'days');
    case 'weeks': return moment().endOf('isoWeek').add(addAmount, 'weeks');
    case 'months': return moment().endOf('month').add(addAmount, 'months');
    case 'years': return moment().endOf('year').add(addAmount, 'years');
    default: return null;
  }
};

/* DAYJS CODE */

export const getFromDate = (cohort, subAmount = 0) => {
  switch (cohort) {
    case 'hours': return dayjs().startOf('hour').subtract(subAmount, 'hour');
    case 'days': return dayjs().startOf('date').subtract(subAmount, 'date');
    case 'weeks': return dayjs().startOf('day').subtract(subAmount, 'day');
    case 'months': return dayjs().startOf('month').subtract(subAmount, 'month');
    case 'years': return dayjs().startOf('year').subtract(subAmount, 'year');
    default: return null;
  }
};

export const getToDate = (cohort, addAmount = 0) => {
  switch (cohort) {
    case 'hours': return dayjs().endOf('hour').add(addAmount, 'hour');
    case 'days': return dayjs().endOf('date').add(addAmount, 'date');
    case 'weeks': return dayjs().endOf('day').add(addAmount, 'day');
    case 'months': return dayjs().endOf('month').add(addAmount, 'month');
    case 'years': return dayjs().endOf('year').add(addAmount, 'year');
    default: return null;
  }
};

/* REST OF THE CODE */

export const getCohort = (timeAlias) => {
  switch (timeAlias) {
    case '24h': return 'hours';
    case '1s': return 'days'; // === 1 week
    case '1m': return 'weeks'; // === 1 month
    case '3m': return 'weeks';
    case '1a': return 'months'; // === 1 year
    default: return 'days';
  }
};

export const getTimeframe = (timeAlias) => {
  const cohort = getCohort(timeAlias);
  let subAmount;
  switch (timeAlias) {
    case '24h': subAmount = 23; break; // cohort = hours
    case '1s': subAmount = 7; break; // cohort = days
    case '1m': subAmount = 4; break; // cohort = weeks
    case '3m': subAmount = 4 * 3; break; // cohort = weeks
    case '1a': subAmount = 12; break; // cohort = months
    default: subAmount = 7;
  }
  return {
    fromDate: getFromDate(cohort, subAmount),
    toDate: getToDate(cohort),
  };
};

Here the results:

"1s" using Moment : fromDate=2020-02-19 ; toDate=2020-02-26
"1s" using Dayjs : fromDate=2020-02-25 ; toDate=2020-02-26

"1m" using Moment : fromDate=2020-02-03 ; toDate=2020-03-01
"1m" using Dayjs : fromDate=2020-02-22 ; toDate=2020-02-26

I’m unable to achieve the same result. Look on CodeSandbox for a better comprehension.

Do you know why I’m unable to get the same result as using moment ? I can alter the code but I need to get fromDate and toDate for 24 hours, 1 week, 1 month, 3 months and 1 year.

Thanks 😉

[iamkun]

@scorsi Check isoWeek here https://day.js.org/docs/en/get-set/iso-week. 😁 And startOf(‘isoWeek’) here https://day.js.org/docs/en/manipulate/start-of

[iamkun]

PS: It could be a great idea to add week and isoWeek to the code like moment have. It’s quite useful 😉

we will