Matching non-modified key also picks up the same modified key

For example if I’m looking for 'shift+left' and 'left', looking for 'left' will also pick up 'shift+left'.

Here is a test case that will fail illustrating the problem:

it('matches only modified hotkey a', () => {
  const check = isHotkey(['shift+a'])
  const a = check(e(65, 'shift'))
  const shifta = check(e(65, 'shift'))
  assert.equal(a, false)
  assert.equal(shifta, true)
})

[ianstormtaylor]

Fixed in 0.1.4, thank you both!

[ericedem]

Ugh sorry for all the churn, after stepping through a few times on both sides, it looks like byKey is getting used implicitly by isKeyHotkey which is what slate is using. Here is an actual test case that fails with the shift null check you initially suggested:

it('matches only modified hotkey left', () => {
  // equivalent to isKeyHotkey('left', e('left', 'shift'))
  const shiftleft = isHotkey('left', { byKey: true }, e('left', 'shift')) 
  assert.equal(shiftleft, true)
})

The problem is that because shiftKey is getting set to null it is just ignored when checking equality of the event: https://github.com/ianstormtaylor/is-hotkey/blob/master/src/index.js#L171

It looks like setting shift to null should only happen onKeyUp? Or maybe the check should just be removed all together?