question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

add `options.save` to all changes

See original GitHub issue

This is an idea. By passing options down in all of the change methods, like @doodlewind did in setValue() it would allow us to have any change not be saved by doing:

change.someMethod(...args, { save: false })

Which seems nicer than the current confusing setFlag('save', false)...setFlag('save', true) workflow surrounding changes. It would probably allow us to remove that weird code.

Issue Analytics

  • State:closed
  • Created 6 years ago
  • Reactions:3
  • Comments:10 (5 by maintainers)

github_iconTop GitHub Comments

3reactions
ianstormtaylorcommented, Oct 31, 2017

To be clear, this would add { save: false } as an optional argument to all change methods, such that you can write:

change.addMarkByKey(node.key, 'bold', { save: false })

But if you do multiple changes, you’ll need to add { save: false } to each of them.

2reactions
ianstormtaylorcommented, Jan 31, 2018

@tobiasandersen that would be great!

Read more comments on GitHub >

github_iconTop Results From Across the Web

How to Change or Add More Options to "Save as type: [File
Just recently, I tried saving a 2 images from Discord, and it gave me the same problem, but the file type it gave...
Read more >
Change settings for saving edits—ArcGIS Pro | Documentation
On the Edit tab, in the Manage Edits group, click the Options dialog box launcher Launcher . · On the Options dialog box,...
Read more >
Saving Changes in Git | How To & Examples - Initial Commit
The primary way to save your changes is to add them to Git's staging area using the git add command and then commit...
Read more >
How to Change or Add More Options to "Save as type
How to Change or Add More Options to "Save as type: [File Type]"? · 1. Go to Control Panel > · 2. From...
Read more >
Save As Change in Photoshop CC - YouTube
After an update back in May you can no longer save a layered file in jpeg or png from the save Save As...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found