Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

change `plugin.render` to `plugin.renderPortal`

See original GitHub issue

Originally I figured always rendering into a portal would be the easiest way to avoid having to deal with plugin render contention. But I’m just realizing that treating it as a HOC stack could work too, so we might end up with:

plugin.render
plugin.renderPortal

And the core plugin can actually just be the final occurrence of plugin.render to render the actual editor logic itself!

Issue Analytics

State:
Created 7 years ago
Comments:10 (10 by maintainers)

Top GitHub Comments

1reaction

ianstormtaylorcommented, Mar 3, 2017

I think there are cases where you don’t want SlateNodePortal, and you might want a SelectionPortal instead, or just a portal that puts things at the top-left/right of the editor. I’ve got both of those cases currently in my setup.

I’d rather just have less, because any of those solutions can be solved by a single plugin.render handler, since then you have full control over where to put the portal.

1reaction

ianstormtaylorcommented, Mar 3, 2017

Fixed in 0.18!