Error when trying to delete selection of list item to paragraph

Do you want to request a feature or report a bug?

Report a bug.

What’s the current behavior?

1. Make a selection from or to the end of a list item (except the last list item) to a paragraph
2. Hit delete/backspace
3. An error is thrown (Could not find a node with key X.) and the selection is not removed

Observed on the Rich Text Slate Example:

Tested with Slate 0.20.3 in latest Chrome (59.0.3071.115) on Windows 7 and 10 (64-bit).

What’s the expected behavior?

The selected text should be deleted.

[ianstormtaylor]

We should already be only allowing selections to reference text nodes, but there may be gaps I don’t know about for sure. Your plan sounds good!

[ExplicitlyImplicit]

This is a bit larger problem than just the issue described above. It boils down to how offsets are used to resolve node operations:

<ul>
  <li>item1</li>
  <li>item2</li>
</ul>

What if I invoke node.getTextAtOffset on the ul-node and specify an offset of 5? I will get the text node inside the second list-item. If I wanted the first list-item I’m out of luck since we cannot express the end of a node using an offset from a parent node (that has more nodes inside it).

I have solved this problem by adding a parameter denoting how node resolution should work when offsets are ‘between’ nodes but I don’t feel like it is a good approach since it is such a big step away from how it currently works with paths and offsets.

If anyone have any input or experience with this issue I’ll be happy to discuss it.