Fix all showstopper bugs in Slate on Android (Help us by reporting and testing bugs)
See original GitHub issueThe purpose of this issue is to consolidate and fix all Android bugs, especially those that are showstoppers (i.e. bugs that if we don’t fix we can’t claim to have Android support).
If you want Android support, you can help make it happen by testing and providing good bug reports. Note: If you can’t recreate the bug, please do not submit it (e.g. needs to e more specific than “sometimes backspace doesn’t work”).
Thank you to the many that have asked what they can do to help with Android. This is the best way to do it. Once I’m off on the next project, it may be a while before I get back here.
Supported Android Versions 8 and 9 (API 26, 27, 28)
Currently supporting Android 8 and Android 9. Working on supporting Android 7 right now. Will post here when you can start testing Android 7.
Where to test Android support
Use my Slate examples site (not the official Slate examples). The official repo does not have my latest Android updates:
https://thesunny.github.io/slate/#/composition/split-join
What to submit in a bug report
Cut and paste these steps into your bug report
Make sure you are using https://thesunny.github.io/slate/ then
Describe the issue including:
- Steps to reproduce
- What you were trying to do
- What happened
- Report anything unusual in the Slate value at bottom of composition example
A GIF showing the issue in action.
http://recordit.co/
Please answer the following
Note: Android API is in the top right corner of the link posted above
[ ] What Android API version are you on?
[ ] What Android device are you using?
[ ] Are you using a `simulator` or `hardware`?
[ ] Which example page were you using?
Issue Analytics
- State:
- Created 4 years ago
- Reactions:9
- Comments:10 (5 by maintainers)
Top GitHub Comments
Thanks for all the submissions guys. I’m working on a new approach so please hold off on bug reports for now. For more information, please see this comment in the IME issue https://github.com/ianstormtaylor/slate/issues/2062#issuecomment-492320466
Bug: Typing any text throws an exception
Severity
Major
Rationale for severity
This is considered major because typing any text will not update the editor state - this means that any edit on the text will not do anything. Although the UI appears to be working as intended, the editor state is not properly updated so you cannot persist/save the new state.
Recording
https://imgur.com/mW8zJFO
Description
Open the editor, tap on the editor to begin typing, then type any character. This will throw the following exception:
This exception is thrown during the
reconcile
function in the Android plugin. This function callssetTextFromDomNode
->node.getLeaves
->compile
. Thecompile
function throws an error becauseannotation
anddecorations
values areundefined
.You’ll see in the video that the Slate’s value as text doesn’t get updated
Android and Slate Info
Additional Comments (if any)
I had to pull the latest project becase the currently deployed examples on https://thesunny.github.io/slate/#/composition/split-join does not have the latest version of slate and slate-react.