Maybe toggleMark shouldn't expect perfect equality?

Do you want to request a feature or report a bug?

Not sure this is a bug

What’s the current behavior?

Currently, when you use toggleMark, you need to pass the exact same object to make it work.

For example:

// Working
transform.toggleMark({ type: 'bold', data: { foo: 'bar' } })
transform.toggleMark({ type: 'bold', data: { foo: 'bar' } })

// Not working
transform.toggleMark({ type: 'bold', data: { foo: 'bar' } })
transform.toggleMark('bold')

What’s the expected behavior?

Maybe when a String is passed, we should remove all the marks of that type, no matter the other properties? Just asking, not sure if this could have side effects. If you agree, I think I can make a pull request.

[ianstormtaylor]

@YurkaninRyan yup it’s definitely possible. We could allow that kind of logic with an extra option potentially, or treat it as the default and make the extra option the strict matching maybe.

[ianstormtaylor]

As of https://github.com/ianstormtaylor/slate/pull/3093 (which was just merged), I believe this issue is no longer applicable, because a lot has changed. I’m going through and closing out any potential issues that are not out of date with the overhaul. Thanks for understanding.