move_node history doesn't pay attention to path changes of other nodes
See original GitHub issueDo you want to request a feature or report a bug?
Bug
Let’s assume we have a node(key: 1)
with path 0,0
and a second one, node(key: 2)
with path 0,1
If we move the node at 0,0 to 0,1 node(key: 2) will no longer be found at 0,1 but 0,0; as node(key: 1) was pushed away Hence no undo is possible
The undo history will have the following record:
newPath: [0, 1]
path: [0, 0]
type: "move_node"
So when we hit undo, there will be an error: Could not find a descendant at path "0,1"
as node(key: 2) is no longer at 0,1
, but at 0,0
Issue Analytics
- State:
- Created 6 years ago
- Comments:6 (2 by maintainers)
Top Results From Across the Web
Moving Nodes Around : r/godot - Reddit
But along the way, I discovered something unfortunate: If I move node hierarchy around in the scene, those strings do not get updated....
Read more >Transform to move Node as last child for a given path #3417
I figured out my particular problem, but it took me incredibly long to understand what can go wrong with this new api: Transforms.moveNodes...
Read more >Make Node module optional [#375397] | Drupal.org
Another argument: does core need Node.module to function? ... Install profiles don't pay attention to dependencies defined in info files, ...
Read more >Can I Obtain Shortest Path/Links to "Root"/Start Node? - Twine
My original thought was that I could use the "back"/"history" functionality, but because there might be internal loops within the structure, ...
Read more >Requests for enhancements - FreeMind - SourceForge
A simple way of storing this type of data would be a flat list of nodes with IDs and then another list of...
Read more >
Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free
Top Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
@ianstormtaylor Seems like this is resolved! At least the example works now.
Thanks!
This issue hasn’t had a response in a while, and it’s unclear if it’s still present in the latest versions of Slate. To keep the issues easier to manage, since there are so many being opened every day, I’m going to close this old one out.
But if you notice that the bug is still happening, please feel free to comment and it can be revisited. It might be an edge case that not many people run into, in which case the fastest way to get it fixed would probably be to write a pull request for it.
Thanks for understanding!