Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

move_node history doesn't pay attention to path changes of other nodes

See original GitHub issue

Do you want to request a feature or report a bug?

Bug

JSFiddle

screen recording 2017-11-15 at 10 11 pm

Let’s assume we have a node(key: 1) with path 0,0 and a second one, node(key: 2) with path 0,1

If we move the node at 0,0 to 0,1 node(key: 2) will no longer be found at 0,1 but 0,0; as node(key: 1) was pushed away Hence no undo is possible

The undo history will have the following record:

newPath: [0, 1]
path: [0, 0]
type: "move_node"

So when we hit undo, there will be an error: Could not find a descendant at path "0,1" as node(key: 2) is no longer at 0,1, but at 0,0

Issue Analytics

State:
Created 6 years ago
Comments:6 (2 by maintainers)

Top GitHub Comments

1reaction

emilbrucknercommented, Aug 10, 2018

@ianstormtaylor Seems like this is resolved! At least the example works now.

Thanks!

1reaction

ianstormtaylorcommented, Aug 8, 2018

This issue hasn’t had a response in a while, and it’s unclear if it’s still present in the latest versions of Slate. To keep the issues easier to manage, since there are so many being opened every day, I’m going to close this old one out.

But if you notice that the bug is still happening, please feel free to comment and it can be revisited. It might be an edge case that not many people run into, in which case the fastest way to get it fixed would probably be to write a pull request for it.

Thanks for understanding!