New lines are removed on copy

Do you want to request a feature or report a bug?

Bug

What’s the current behavior?

This has been reported earlier https://github.com/ianstormtaylor/slate/issues/1635 and then a related PR was created https://github.com/ianstormtaylor/slate/pull/1644.

Somehow it doesn’t work as expected with slate@0.34.2.

In Action

What’s the expected behavior?

The new lines must be copied over

[ianstormtaylor]

This is fixed in the latest version of slate-react, thanks @Slapbox!

[tobiasandersen]

Hm, what’s weird is that it works fine in our editor — but not in the examples. I haven’t investigated what differs though. Anyway, sorry for breaking stuff. Reading on mdn, it sounds like innerText should do the trick:

As a getter, it approximates the text the user would get if they highlighted the contents of the element with the cursor and then copied to the clipboard.

But unfortunately, innerText have the same problem as textContent in that it doesn’t break child nodes.

I’m not sure about the solution proposed above though, since I believe there’re important distinctions between the different zero width space attributes (for IMEs I think?), and that it would probably also add extra line breaks for legacy browsers that don’t support the clipboard api. Maybe it could be altered to solve those cases as well though?

Another solution would be to add back some old logic, where we actually add the dummy div to the DOM, select it, and then use the selection to retrieve the text. I don’t know why, but doing it this way seems to preserve line breaks. Sadly we’d have to add back some COMPAT stuff for Firefox for this to work properly.