question-mark
Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

renderEditor props.children is undefined

See original GitHub issue

Do you want to request a feature or report a bug?

Bug

What’s the current behavior?

Since upgrade to newest version of slate 0.42.2 from 0.41.0 and slate-react 0.19.3 from 0.18.0 renderEditor, which I use to wrap children to generate toolbar doesnt work anymore, props.children is undefined, I think the rest props is still there

I prepared demo showing this issue: https://codesandbox.io/s/1z1lyjp00q Is this some regression or I do sth wrong?

What’s the expected behavior?

renderEditor should have access to props.children

Issue Analytics

  • State:closed
  • Created 5 years ago
  • Comments:5 (5 by maintainers)

github_iconTop GitHub Comments

1reaction
SmilinBriancommented, Oct 16, 2018

I think it’s worth adding to the plugins documentation. Pretty sure I saw a question essentially just like this on the Slate Slack a few days ago, so you’re not the only one confused about next and rendering.

0reactions
klis87commented, Dec 17, 2018

@ianstormtaylor I am closing this issue as PR is there if you would like to merge it, if u wanna change sth just give me a hint in the PR

Read more comments on GitHub >

github_iconTop Results From Across the Web

ReactJS - {this.props.children} is undefined - Stack Overflow
You have to pass children to Dashboard: class App extends Component { render() { return( <div id="container"> ...
Read more >
this.props.children undefined | React
It refers to the children between // last line's `<App></App>`, which are undefined. console.log(this.props.children); ...
Read more >
General Props | Docs and API Reference - React Data Grid
default: undefined. Specifies a value for cell selection. This is a controlled prop. For the uncontrolled version, see ...
Read more >
Everything you need to know about the children prop in React
In this article, we will see the importance of children prop. So let's get started. When we render any JSX, React converts that...
Read more >
A Complete Guide To props.children In React - codeburst
Please note that, as mentioned in the React documentation, false , null , undefined , and true are valid children, but they will...
Read more >

github_iconTop Related Medium Post

No results found

github_iconTop Related StackOverflow Question

No results found

github_iconTroubleshoot Live Code

Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start Free

github_iconTop Related Reddit Thread

No results found

github_iconTop Related Hackernoon Post

No results found

github_iconTop Related Tweet

No results found

github_iconTop Related Dev.to Post

No results found

github_iconTop Related Hashnode Post

No results found