scroll-to-selection: doesn't scroll all the way down
See original GitHub issueDo you want to request a feature or report a bug?
Bug
What’s the current behavior?
It doesn’t scroll all the way down:
It should scroll all the way down:
The problem seems to be here:
const selectionFocusTop = backward ? selectionRect.top : selectionRect.bottom
Should be the other away:
const selectionFocusTop = backward ? selectionRect.bottom : selectionRect.top
EDIT: updated proposal to fix
Issue Analytics
- State:
- Created 6 years ago
- Reactions:1
- Comments:11 (5 by maintainers)
Top Results From Across the Web
HTML Scrolling to section doesn't scroll all the way down
I want my buttons on my navbar to scroll to a certain section, but it doesn't scroll all the way down, and it...
Read more >ScrollViewProxy scrollTo will cras… | Apple Developer Forums
ScrollViewProxy scrollTo will crash when scrolling outside of bounds of previous (not current) List data source/array in iPad and iOS 16 beta.
Read more >Prototype scrolling with overflow behavior - Figma Help Center
Vertical scrolling allows users to swipe or scroll up and down within a frame. Use this behavior to mimic scrolling down a long...
Read more >Window scrollTo() Method - W3Schools
For the scrollTo() method to work, the document must be larger than the screen, and the scrollbar must be visible. See Also: The...
Read more >Element.scrollIntoView() - Web APIs | MDN
The Element interface's scrollIntoView() method scrolls the element's ancestor containers such that the element on which scrollIntoView() is ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
Okay, I’ll take a look. Thanks for the bug report.
Let’s discuss this further in https://github.com/ianstormtaylor/slate/pull/1462.
Closing this as @echenley 's PR makes an acceptable solution to this.