Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

shouldNodeComponentUpdate is not deprecated in slate-react plugins documentation

See original GitHub issue

Do you want to request a feature or report a bug?

Report a bug

What’s the current behavior?

Currently slate-react plugins documentation doesn’t say that shouldNodeComponentUpdate is deprecated. However, console shows warning:

As of slate-react@0.22 the ‘shouldNodeComponentUpdate’ middleware is deprecated. You can pass specific values down the tree using React’s built-in “context” construct instead.

What’s the expected behavior?

Documentation should say that shouldNodeComponentUpdate is deprecated and explain what should be used instead.

Issue Analytics

State:
Created 4 years ago
Comments:5 (3 by maintainers)

Top GitHub Comments

2reactions

dmitryplatonovcommented, Jul 18, 2019

Yes, I’m having the same problem. Force refresh plugin no longer works because of this change. Would be nice to have at least working example.

0reactions

ianstormtaylorcommented, Nov 28, 2019

I believe that this may be fixed by https://github.com/ianstormtaylor/slate/pull/3093, which has changed a lot of the logic in Slate and slate-react especially. I’m going to close this out, but as always, feel free to open a new issue if it persists for you. Thanks for understanding.