Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Unable to drop files on void nodes

See original GitHub issue

Do you want to request a feature or report a bug?

Bug

What’s the current behavior?

Currently, when you drop a file on a void node, nothing happens. This is because the code here returns early in the onDrop function in content. It seems like the isInEditor function was designed to return false on void nodes or their content.

What’s the expected behavior?

We should be able to drop a file on the void node, and have the event continue as on a non-void node.

Next Steps

I’m not sure though if:

We want to add a function testing if the drop is on a void node to modify this condition OR modify isInEditor to NOT return false on void nodes or their content.
And if so what is the most reliable way to test if a DOM element is a child of a void node.

Issue Analytics

State:
Created 6 years ago
Comments:9 (8 by maintainers)

Top GitHub Comments

2reactions

oyeanujcommented, Aug 16, 2017

Sounds good, I’ll take a shot at it! This would also remove the need for checking for void nodes specifically.

1reaction

ianstormtaylorcommented, Aug 15, 2017

@oyeanuj good find. I think an easy way to solve this might be to make it so that we have two different methods to use:

isInEditor which is the current one without the editable check.
isEditableInEditor which calls to isInEditor and then adds the editable check too.

And change all the current use cases to use the new one, with the onDrop one not caring about whether the node is editable.

Are you down to make that change? Thanks!