Undoing inline marks doesn't work as expected

Do you want to request a feature or report a bug?

Feel free to close this report if it’s a duplicate – I searched “undo” but nothing seemed to quite fit. I am not currently developing with Slate.js but discovered a reproducible bug in the example editor.

What’s the current behavior?

Tested in Chrome 58 on Mac

1. Visit http://slatejs.org/#/rich-text
2. On the top paragraph of the editor, select “ch text, mu”
3. Hit delete.
4. Hit cmd-z.

Current behavior: The re-done text is “mu ch”

What’s the expected behavior?

The editor should restore text to the original state: “ch text, mu”

[erquhart]

Some of the selection bugginess seemed to maybe share the same cause, so I was trying to determine if there’s a centralized ticket or effort for that cause, but it doesn’t sound like there’s a single underlying issue. Just learned, for example, about trackpad dragging having a 300ms timeout enforced at the OS level for Mac, which botches quick select/backspace maneuvers.

I’ll probably revisit this once we get through our initial implementation.

[kgdev]

In Transforms.removeMarkAtRange,

adding the following logic seems to solve the problem:

      const ranges = text.getRanges()
      let rangeIndex = 0
      ranges.forEach(range => {
          const {marks, text} = range
          const rangeLength = text.length

          if (marks.has(mark)) {
              const start = Math.max(index, rangeIndex)
              const end = Math.min(index + length, rangeIndex + rangeLength)

              if (start < end) {
                transform.removeMarkByKey(key, start, end - start, mark, { normalize })
              }
          }

          rangeIndex += rangeLength
      })