Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

void blocks have space above

See original GitHub issue

Hey, as you can see here: http://slatejs.org/#/embeds, blocks have spaces above, due to the data-slate-void > span elements that have some inline styles. If all these inline styles display: inline-block; vertical-align: top; width: 0px; height: 0px; color: transparent; are changed to only position: "absolute", things work pretty good.

ps. Why do we need these inline styles forced? Would it be possible to introduce a flag (stylingMode="className") to allow styling these via css for example`?

Issue Analytics

State:
Created 6 years ago
Comments:8 (5 by maintainers)

Top GitHub Comments

1reaction

ianstormtaylorcommented, Oct 14, 2017

@bkniffler good point, dunno what I was thinking. I pushed another release that totally omits the spacer, and added some read-only rendering tests to prevent it from breaking in the future hopefully.

0reactions

bknifflercommented, Oct 14, 2017

Thanks for the fix! But in readOnly, the data-slate-void will now contain:

<div data-slate-void="true" data-key="462">
  <div>
    <span data-key="463">
      <span data-offset-key="463-0"> </span>
    </span>
  </div>
  <div contentEditable="false">
....

and thus have a space again (only in readOnly).

Is this somehow necessary? Could we get rid of the first div?