Refinement for top level object failed when field has refinement

Using the validators below, the top level PasswordDoNotMatch refinement will not be called. On the other hand, if we change to newPassword: string() (i.e. no refinement in any of the nested fields), then the PasswordDoNotMatch will be called.

const PasswordValidator = refine(string(), 'MinimumLength', (pw) => pw >= 8);
const ChangePasswordValidator = object({
    newPassword: PasswordValidator,
    confirmPassword: string(),
});
const RefinedChangePasswordValidator = refine(ChangePasswordValidator, 'PasswordDoNotMatch', (values) => {
    return values.newPassword == values.confirmPassword;  // This will not be called
});

[ianstormtaylor]

@Gelio that sounds great! Actually I believe there is already an error.refinement field which might give us exactly what we need to make that check in the run function.

[Gelio]

Great! Sure, I’ll try to prepare something over the weekend.

Just to be clear, I will disambiguate the errors so that we have specific validator and refiner errors and then run the refiner if there were no validator errors on the value itself or its entries.