test: move backend-specific backend tests to the larger suite
See original GitHub issueIssue rephrased from: https://github.com/ibis-project/ibis/pull/3988#issuecomment-1138599760.
Since https://github.com/ibis-project/ibis/pull/3988, database loading is done automatically by the pytest
backend
fixtures. In theory, ci/datamgr.py load
should not be necessary anymore.
However, we cannot remove ci/datamgr.py load
from the CI. Some of the backends have tests that run against backend data, but aren’t “backend” tests in that they do not run across all the backends. The non-backend-backend tests and the proper backend tests expect the same loaded data. Without loading that data at some point, the tests will fail to find the things they need to run the test.
We want to move the backend-specific backend tests to the larger suite. We’ll have to go test by test and remove duplicated tests as well as notimpl/notyet/never-mark the ones that don’t work on the other backends.
The places to start looking are ibis/backends/{sqlite,postgres,clickhouse}/tests/test_functions.py. Much of the duplicated backend testing lies there.
Issue Analytics
- State:
- Created a year ago
- Comments:5 (5 by maintainers)
Top GitHub Comments
Let’s close this out! We can continue to do this as time permits.
Thanks for your work on this @anjakefala!
I think we do. I suspect this will need to be tackled in a few PRs, since there are a good number of backend specific tests.
I’ll suggest the following order: