[BUG] temp file not being deleted when building

Information

1. Apktool Version (apktool -version) - 2.6.0
2. Operating System (Mac, Linux, Windows) - Windows
3. APK From? (Playstore, ROM, Other) - probably not relevant

Steps to Reproduce

1. apktool b -o out extractedFolder
2. Monitor the %TEMP% folder; during build, two APKTOOL{longnumber}.tmp files are created, and one of the is removed again. The other stays there.

Note that this only occurs when (re-)building, not when decompiling an .apk. After digging a bit in the source, I suspect the following lines in buildManifest() to be the problem:

https://github.com/iBotPeaches/Apktool/blob/9bdf3855384414d5e1060bfef263bb0e5b07460a/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java#L548-L549

Here, the temporary file is being created and then deleted again (I guess to get the temp filename). Then the filename is used in a call to aaptPackage(), but afterwards it isn’t deleted.

Note that buildResourcesFull() also creates a temp filename, but deletes the created file again in line 512, and that’s the difference to buildManifest():

https://github.com/iBotPeaches/Apktool/blob/9bdf3855384414d5e1060bfef263bb0e5b07460a/brut.apktool/apktool-lib/src/main/java/brut/androlib/Androlib.java#L512

[MFinkBK]

Works! I tested with apktool-2.6.1-797fc3-SNAPSHOT-small.jar. Thanks for the effort to fix this bug, and for making apktool in the first place!

[MFinkBK]

I’d like to test the PR, but unfortunately the GitHub action doesn’t provide a built apktool.jar, only when merged to master…