Compression Issues on Windows

My deployment environment is linux, however I am working on development in Windows; my code might work in linux, but it’s certainly not working on Windows and having unusual behavior.

I tried setting compress to true, and had problems… but then I realized that perhaps my Windows installation didn’t have the compression binaries that rotating-file-stream is expecting, so I overrode it with my own function and having the same problem:

let compressFunction = (source, dest) => 'tar -czf "' + dest + '" "' + source + '"';

if (accessLogging) {
  let accessLogStream = rfs(accessLogName, {
    interval: '60s',
    compress: compressFunction,
    path: path.join(accessLogPath, accessLogName)
  })
  app.use(morgan(accessLogFormat, { stream: accessLogStream }))
}

When compress isn’t enabled, it rotates as expected. However with compress specified as above, the files that are written do appear to be blank (pre-compression) and then aren’t actually compressed.

It appears when it’s trying to compress the files, it’s executing the temporary file itself, as I get a prompt to “Choose app to open SUCHANDSUCH.tmp” at the interval about on par with what I have specified.

[Alpha4615]

Thanks, keep me apprised.

On Wed, Jun 19, 2019, 10:38 Daniele Ricci [e-mail] wrote:

Hi @Alpha4615 https://github.com/Alpha4615 ,

I did a quick check and I saw there is a lot of work to do in order to make rotating-file-stream fully compliant with windows; so to unlock you, I hope solution we previously discussed could be enough, on the other hand I’ll work in next days (or better next weeks) to make rotating-file-stream compliant with windows as well.

Hope this helps, iCC

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/iccicci/rotating-file-stream/issues/37?email_source=notifications&email_token=AA252YKRNNS3OQDPT2B4CDLP3JAGRA5CNFSM4HYYITJKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODYCCT2A#issuecomment-503589352, or mute the thread https://github.com/notifications/unsubscribe-auth/AA252YKF3STT6JI7NO5ZW5TP3JAGRANCNFSM4HYYITJA .

[iccicci]

Hi @Alpha4615 ,

I just released v2.0.0, it should be fully Windows compliant (at least all tests are now OK).

Hope this helps.