Example use of generator fails with "write after end" error.

The example use of a generator function in the documentation fails with “write after end” error:

Simple program to reproduce this is:

var rfs    = require('rotating-file-stream');

function pad(num) {
    return (num > 9 ? "" : "0") + num;
}

function generator(time, index) {
    if(! time)
        return "file.log";

    var month  = time.getFullYear() + "" + pad(time.getMonth() + 1);
    var day    = pad(time.getDate());
    var hour   = pad(time.getHours());
    var minute = pad(time.getMinutes());

    return "/storage/" + month + "/" + month +
        day + "-" + hour + minute + "-" + index + "-file.log";
}

var stream = rfs(generator, {
    size:     '1M',
    interval: '30m'
});

setInterval(function () {
    stream.write('xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx');
}, 10);

Using node 8.4.0 on Bash on Windows 10.

[iccicci]

Hi @normancarcamo ,

your generator function takes not care neither of parameter index nor of parameter time (apart from first check).

Please pay attention to the note of this paragraph: https://www.npmjs.com/package/rotating-file-stream#function-filenametime-index returned rotated file name must be function of both parameters time and index.

Hope this helps, iCC

[normancarcamo]

@iccicci Thanks bro, I understand and I just did a test of what you have said and its true, but I think that using the following format “hh:mm:ss.log.(index|counter)” is enough for me (well in my case its ok), by the way my issue is gone now, it is working as I’d expect using “pipe” instead of the style “write(chunk)”, here is a copy of my rotator.js config file:

const rfs = require('rotating-file-stream');

let counter = -1;

function generator(time, index) {
  if (!time) return "logs.log";

  const dateiso = new Date().toISOString();
  const datestr = dateiso.substr(0, 10);
  const timestr = dateiso.substr(11, 8);
  counter++;
  console.log('Counter:', counter, 'Index:', index, 'Time:', time); // testing purposes...

  return `${datestr}/${timestr}.log.${counter}`;
}

const stream = rfs(generator, {
  path: `${process.cwd()}/logs`,
  size: '500K',
  interval: '1d',
  maxFiles: 5,
  maxSize: '5M',
  initialRotation: true
});

process.stdin.pipe(stream);

Terminal output:

Counter: 0 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 1 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 2 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 3 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 4 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 5 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 6 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 7 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 8 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 9 Index: 1 Time: 2018-08-17T06:00:00.000Z
Counter: 10 Index: 1 Time: 2018-08-17T06:00:00.000Z

And this is my logs directory:

Oh and to finish I think that using the option “initialRotation” (in my case again) works well instead of ignoring it whenever the option “rotationTime” is set to true.

😃 thanks its a great utility, I was doing this directly using logrotate utility in debian and the problem that I had there was that whenever a file is rotate and new logs arrive to be written they turn out be corrupted due to the “fd” is attached to the initial process that runs it, the solution that I was doing was stop the pid and the reenable it but it looks a bit meesy.

I was looking for packages on npm to see if there was a solution for node and I saw this 😃 and it’s doing it very well.