Add support of runtime Id creation

I updated my project based on the recent commit of moko-widgets-template, so using 0.1.0-dev-18 now. And my code previously working with -dev12 throws an exception on Android run now.

E/AndroidRuntime: FATAL EXCEPTION: main
    Process: org.example.app.debug, PID: 18128
    dev.icerock.moko.widgets.utils.AndroidIdConflictException: id 0x7F081AB9 already used by org.example.mpp.MainScreen$createInput$1$2, it conflict with org.example.mpp.MainScreen$createInput$1$2
        at dev.icerock.moko.widgets.utils.IdExtKt.getAndroidId(IdExt.kt:45)
...

I stripped down the test case to minimum for reproducing the error:

• use the current moko-widgets-template
• replace MainScreen.kt with:

/*
 * Copyright 2019 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license.
 */

package org.example.mpp

import dev.icerock.moko.fields.FormField
import dev.icerock.moko.fields.liveBlock
import dev.icerock.moko.resources.desc.StringDesc
import dev.icerock.moko.resources.desc.desc
import dev.icerock.moko.widgets.*
import dev.icerock.moko.widgets.core.Theme
import dev.icerock.moko.widgets.core.Widget
import dev.icerock.moko.widgets.screen.Args
import dev.icerock.moko.widgets.screen.WidgetScreen
import dev.icerock.moko.widgets.style.view.SizeSpec
import dev.icerock.moko.widgets.style.view.WidgetSize
import org.example.library.MR

class MainScreen(
    private val theme: Theme
) : WidgetScreen<Args.Empty>() {

    private fun createInput() : Widget<*>{
        return with(theme) {
            input(
                size = WidgetSize.WrapContent,
                label = const(MR.strings.hello_world.desc() as StringDesc),
                field = FormField(initialValue = "", validation = liveBlock { null }),
                id = object : InputWidget.Id {}
            )
        }
    }

    override fun createContentWidget() = with(theme) {
        constraint(size = WidgetSize.AsParent) {
            val scroll = +scroll(
                size = WidgetSize.Const(SizeSpec.MatchConstraint, SizeSpec.MatchConstraint),
                id = object : ScrollWidget.Id {},
                child = linear(
                    size = WidgetSize.Const(SizeSpec.AsParent, SizeSpec.WrapContent)
                ) {
                    +createInput()
                    +createInput()
                    +createInput()
                })

            constraints {
                scroll.topToTop(root.safeArea)
                scroll.leftRightToLeftRight(root.safeArea)
                scroll.bottomToBottom(root.safeArea)
            }
        }
    }
}

• run in Android emulator

The input fields are generated dynamically, the id of the returned input field is a new object, but it seems that the moko-widgets lib thinks it’s the same. Or is the code just wrong and it’s not the right way to do it?

[Alex009]

i think we can add specific implementation of ID with string id, not class name…i mark issue as enhacement

[Alex009]

@Gamadril you can test it now on dev repo - https://bintray.com/beta/#/icerockdev/moko-dev/moko-widgets/bd962b3?tab=overview