tree-view.js and toggling visibility of local treeview
See original GitHub issueHey there, first I want to say thank you for making this awesome plugin. I used Atom with a separate SFTP client previously and that way is so much more of a hassle. Keep up the great work.
The only thing I found to be some what of a minor problem is the local treeview doesn’t seem to want to go away to expose just remote-ftp. If I want more space for my code and quickly toggle remote-ftp into view, once I toggle it away, the local treeview doesn’t seem to want to go also.
After looking at the source code, I now understand remote-ftp is like a child node of the local treeview, so when it’s launched, there the local treeview is, too. You seem to have made a setting option for this toggling scenario, but remote-ftp is not recognizing the setting.
From line 242 of blob/master/lib/views/tree-view.js
if (atom.config.get('Remote-FTP.hideLocalWhenDisplayed')) hideLocalTree(); else showLocalTree();
I put this into my remote-ftp configuration:
“hideLocalWhenDisplayed”:true
But there was no change. Then it hit me, you’re calling atom.config.get() so after going to File -> Config in Atom and adding "Remote-FTP.hideLocalWhenDisplayed": true
to Atom’s config.cson, what happens now is it toggles between which view is displayed, but the panel stays open.
But what I think it’s supposed to do, and what I essentially want is for the entire panel to toggle between being hidden and remote-ftp. I’m trying to save myself having to use two different keyboard shortcuts because my brain doesn’t seem to like doing Ctrl+Alt+o and Ctrl+\ in quick succession, even after dozens of times over.
I don’t yet have any experience with Atom’s plugin system, so I wish I could tinker with this problem myself and submit a pull request. Any help with this annoyance would be greatly appreciated. Cheers. 😃
Issue Analytics
- State:
- Created 7 years ago
- Reactions:2
- Comments:7
Top GitHub Comments
So you want: Atoms treeview is hidden and remote-ftp one is visible and you toggle the Remote-ftp treeview -> no treeview is visible. correct?
I have the same problem since many versions ago. It’s annoying 😦 I only use local tree view for local projects, for this I always hidde this panel when use remote projects. But now when you open a project or toggle remote panel, the local panel always come back to appear. hideLocalWhenDisplayed isn’t a solution because only toggle between local and remote panels as @samifouad said. My temp solution is hide the local panel using my personal stylesheet. But it’s tedious comment and uncomment this lines depending of project type.
I hope u can fix this because this package it’s one of my favorites. Good job.