VB -> C#: Converter takes the property name from interface instead of the concrete class.

Input code

Here is the code: https://github.com/Yozer/VBConverterBug Converting project ToConvert results in code that doesn’t compile.

Erroneous output

            var test = new Class1() { InterfaceProperty = "xxx" };
            Console.WriteLine(test.InterfaceProperty);

Expected output

            var test = new Class1() { OtherProperty = "xxx" };
            Console.WriteLine(test.OtherProperty);

Details

• Product in use: VS extension
• Version in use: 8.2.4
• Did you see it working in a previous version? No
• Any other relevant information to the issue, or your interest in contributing a fix.

Looks like the converter takes the property name from the interface instead of the concrete class.

[Yozer]

I don’t think my fix is correct. It works fine for me because all my interfaces and their implementations are in another project that is not being converted. For another case (when we’re converting usages, interfaces & implementations) it incorrectly renames methods.

[GrahamTheCoder]

Looks good from a quick skim. I’ll have to look more closely at the condition you’ve used. I suggested TakeWhile in the hope of covering the situation where A -> B -> C, and only A and C are being converted. But that was just off the top of my head, and may not be optimal for this case or others

If you remove the “Skip” on this test, it should run locally: https://github.com/icsharpcode/CodeConverter/blob/master/Tests/CSharp/MultiFileSolutionAndProjectTests.cs#L22 (Apologies - A build server change broke it a while ago and I haven’t had time to investigate a fix for it yet). There’s a source solution which you could ensure has the vb project referencing the c# project then create a test case in