ACS_DEFAULT_REDIRECT_URL has no effect
See original GitHub issueIt seems like LOGIN_REDIRECT_URL
overrides ACS_DEFAULT_REDIRECT_URL
setting.
On accessing saml2/login/
endpoint with no next
parameter, the next_path
defaults to LOGIN_REDIRECT_URL
https://github.com/IdentityPython/djangosaml2/blob/02f4a1987078a0e1e0e15c24b22157618dab7dbe/djangosaml2/views.py#L135-L137
This next_path
is used to set value of relay_state
here:
https://github.com/IdentityPython/djangosaml2/blob/02f4a1987078a0e1e0e15c24b22157618dab7dbe/djangosaml2/views.py#L318-L331
Now in post method of AssertionConsumerServiceView
, value of ACS_DEFAULT_REDIRECT_URL
is retrieved, but that’s get overridden by the RelayState
parameter of POST request, which was set in saml2/login
if I am not wrong.
Hence ACS_DEFAULT_REDIRECT_URL
has no result in this scenario.
Issue Analytics
- State:
- Created 2 years ago
- Comments:9 (9 by maintainers)
Seeing as I only have a limited amount of time left to spend on this I decided it would be easier to just attempt to resolve this issue now 😃
Didn’t get enough time yesterday to look into #279. From the changes I see in https://github.com/IdentityPython/djangosaml2/commit/3be1bbf1530e62e8db169f67afe8023f3c1c98dc, the issue seems to get fixed. Thank you very much @peppelinux and @jaap3.