Passing `duration` or `fps` has no effect on the output GIF using PillowPlugin

import imageio.v3 as iio
import matplotlib.pyplot as plt

gif_path = "test.gif"
frames_path = "{i}.jpg"

n = 20
plt.figure(figsize=(4,4))
for x in range(n):
    plt.scatter(x/n, x/n)
    plt.xlim(0, 1)
    plt.ylim(0, 1)
    plt.savefig(f"{x}.jpg")

frames = np.stack(
    [iio.imread(f"{i}.jpg") for i in range(n)],
    axis=0
)

iio.imwrite(gif_path, frames, fps=1, loop=0)

I’ve tried duration=1000 too

[FirefoxMetzger]

Of course I can. It would live in PillowPlugin.write.

The way it works under the hood is that imopen selects the plugin, instantiates it, and returns it (a typical factory). imwrite calls imopen internally to figure out the plugin to use and then calls plugin.write to do the actual writing.

[FirefoxMetzger]

No, I think you got that one right. The old pillow plugin added fps on top of pillow’s native duration. I didn’t port that addition into the new PillowPlugin because it is redundant. It is also more limiting because duration allows an iterable with one duration per frame whereas something like fps=[1, 1/50, 1/25, 1/25] seems a bit odd.

That said, I see how fps seems like the more intuitive keyword compared to duration so we could reintroduce it as a thin wrapper around (and coexistant with) duration. (Subject to resolving the above odd edge case) What do you think?