Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

order rule should support "node:" protocol for imports

See original GitHub issue

The order rule should support the node: protocol for builtin node modules.

Issue Analytics

State:
Created 2 years ago
Reactions:4
Comments:29 (19 by maintainers)

Top GitHub Comments

3reactions

nicolashenrycommented, May 7, 2021

What downsides ? If you talk about node compatibility, it is only important for library developers, not for application developers.

For advantages, there are some explained in this proposal https://github.com/nodejs/node/issues/38343 which is about to use it by default in node documentation examples.

So if you disagree, I suggest you to give your counter arguments to the Node.js team before it is done (for now there are almost only positive reactions).

2reactions

iamnapocommented, May 14, 2021

Hi, I don’t know if it helps, but in my case, with a similar setup (node v16, is-core-module v2.3.0, resolve v1.20.0), import order is fine, but if I have a newline between the two import statements, I get: There should be no empty line within import group import/order. If I replace node:fs with fs, the error goes away. The rule’s config is: "import/order": ["error", { "newlines-between": "always" }]

@ljharb fyi: This is indeed fixed in v2.23.0