Two circular dependencies
See original GitHub issueNot that they are bad, but they smell like possible o crap mistakes.
run-context.ts
imports command.ts
and vice versa. It’s via a function, but still not immune.
Also a more complex circular dependency:
run-context.ts -> plugin.ts -> extensions.ts -> run-context.ts
It’s worth checking if we can properly structure the code so there could be no chance of a circular dependency.
Issue Analytics
- State:
- Created 6 years ago
- Comments:5 (5 by maintainers)
Top Results From Across the Web
Circular dependency - Wikipedia
In software engineering, a circular dependency is a relation between two or more modules which either directly or indirectly depend on each other...
Read more >How to Analyze Circular Dependencies in ES6? - Railsware
According to Wikipedia, In software engineering, a circular dependency is a relation between two or more modules which either directly or ...
Read more >How to Eliminate Circular Dependencies from Your JavaScript ...
Circular dependencies (also known as cyclic dependencies) occur when two or more modules reference each other.
Read more >Circular Dependencies in Spring - Baeldung
A quick writeup on dealing with circular dependencies in Spring: how they occur and several ways to work around them.
Read more >The vicious cycle of circular dependencies in microservices
A circular dependency is defined as a relationship between two or more application modules that are codependent. Circular dependencies in a ...
Read more >Top Related Medium Post
No results found
Top Related StackOverflow Question
No results found
Troubleshoot Live Code
Lightrun enables developers to add logs, metrics and snapshots to live code - no restarts or redeploys required.
Start FreeTop Related Reddit Thread
No results found
Top Related Hackernoon Post
No results found
Top Related Tweet
No results found
Top Related Dev.to Post
No results found
Top Related Hashnode Post
No results found
Top GitHub Comments
The relationship from Command to RunContext is interface only, not data, so it wouldn’t cause any runtime issues like serialization problems.
Same with the plugin/extension gauntlet. Ownership is only 1 way, even though the interfaces are in both spots.
I love how TypeScript knows what to do.
I’m going to call this one
wontfix
… but feel free to bring it up again if we run into any issues!