Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Fix strategy precedence when applied to `html`

See original GitHub issue

Currently, the assignable option makes the themes assignable (the manner depends on the choosen strategy), but the :root theme takes precedence if the strategy is applied to html.

For instance, <html data-theme="dark"> won’t work because :root will take precedence.

I didn’t realize this before because I was used to apply the strategies on body.

The “workaround” is to not use the strategy on html, but on anything else.
The fix is to modify the assignable themes’ selectors.

Issue Analytics

State:
Created 4 years ago
Comments:6 (3 by maintainers)

Top GitHub Comments

1reaction

innocenzicommented, Aug 18, 2020

Well, you can use addTheme for it to not be a “default” theme, but if you don’t have a default theme, the plugin will throw an error.

I’ll change that in the next version, it will only send a warning. You’ll have to set the theme targetable and use a name on it, and it won’t use :root.

Will that solve your issue?

0reactions

innocenzicommented, Aug 18, 2020

Alright. That’ll be fixed in the next version, then. 👍