classnames lib - Object Syntax

This isn’t a bug or a problem that requires fixing.

I noticed that this project uses classnames, which is great, but in many places the project is using ternary operators for toggling classes when the object style eliminates this need completely.

Example:

• current

const componentClassnames = classnames([
  styles.component,
  isVisible ? styles.isVisible : null,
  flipHorizontal ? styles.flipHorizontal : null,
  flipVertical ? styles.flipVertical : null,
]);

• could instead be

const componentClassnames = classnames(styles.component, {
    [styles.isVisible]: isVisible,
    [styles.flipHorizontal]: flipHorizontal,
    [styles.flipVertical]: flipVertical,
});

when classnames receives an object it concatenates the keys for any values that are true.

I think the latter reads much cleaner.

This isn’t critical but I figured it was worth mentioning. If there was a specific reason this style was avoided, then I apologize in advance. If this is something everyone likes, I will be happy to put together a PR for these changes.

Love all the work 🙂

[rvcas]

@daniloprates yes I think so

[daniloprates]

Ok changes are in #1465

@lrosa007 that’s an awesome contribution. Is the PR ready to be reviewed?

Thanks, Danilo