New viewmodel for every instance of same fragment

Describe the bug I have a fragment which has a personId to show details of a person

class PersonDetailsFragment : Fragment {
   val personId: Int by lazy { intent.extras.getInt("personId") }
   val viewModel: PersonViewModel by viewModel()

   override fun onCreate(savedInstanceState: Bundle?) {
        super.onCreate(savedInstanceState)
        viewModel.personDetailsLiveData.observe(this, Observer<List<Cryptocurrency>> {
           // show person
        })
    }
}

To Reproduce Steps to reproduce the behavior:

1. Open a person (PersonFragment)
2. Click on a friend of this person
3. It opens a new instance of PersonFragment but gets the viewmodel of the previous PersonFragment
4. The app crashes with the following exception

java.lang.IllegalArgumentException: Cannot add the same observer with different lifecycles

Expected behavior If i open a new instance of the same fragment it should also create a new viewmodel.

Koin project used and used version (please complete the following information): koin-android-architecture v0.9.3

[arnaudgiuliani]

Hello,

you are injecting with by inject().

You have to use by viewModel() to inject and bind your viewModel to the lifecycle owner: val viewModel: PersonViewModel by viewModel()

[joelfernandes19]

@arnaudgiuliani I’m using version 2.0.0-beta-1, and I’m facing the exact same issue as described above. I have declared my ViewModel classes with viewModel dsl keyword.

I’m also using Navigation Component to navigate between fragments. When I navigate from fragment A to B, and then navigate back to A, a new ViewModel is created and the observer is called multiple times.

Is there something that I’m doing wrong?