Formatter should indent wrapped imports to same alignment as previous line

use piston_window::{Button, clear, Context, Event, Input, Key, PistonWindow, text, types,
    Transformed};

Should be formatted to

use piston_window::{Button, clear, Context, Event, Input, Key, PistonWindow, text, types,
                    Transformed};

According to rustfmt 0.6.3:

 use piston_window::{Button, clear, Context, Event, Input, Key, PistonWindow, text, types,⏎
-    Transformed};⏎
+                    Transformed};⏎

@matklad Is the goal of the intellij-rust formatter is to default to what rustfmt does? Just want to make sure I’m not reporting issues that aren’t actually in scope for where intellij-rust wants to go (but I assume this would be a positive).

[matklad]

Is the goal of the intellij-rust formatter is to default to what rustfmt does?

Yes!

[alygin]

rustc (and I think cargo as well) uses some checks to find out if it’s running in an environment that supports colors. If not, the colored output is suppressed. But you can force it by passing the --color=always option to the command (or explicitly suppress it by passing --color=never).

Cargo also supports the --color option, but it relies on other programs. For instance, cargo build executes rustc and passes some of its own options to the compiler, including --color (if it has been specified explicitly). But when you execute cargo clippy, the --color option is not passed to rustc (which is the actual clippy’s engine) because cargo treats clippy as a pluggable command and makes no assumptions on what options it supports.

So, cargo build --color=always forces colored output in the underlying rustc command, while cargo clippy --color=always does not.

The IntelliJ command output window handles output in a special way (for instance, it paints all the stderr output red), so we have to reconfigure it a bit and add the --color=always option every time we run a command that we know supports colored output.

The IntelliJ terminal (and the outside one) works another way and is treated by rustc (as well as by cargo) as color-friendly. So, no additional actions needed to force colors.

I don’t know, what exactly is the difference in implementation of these two windows. Maybe Alexey can answer this. But the fact is that when you execute cargo clippy --color=always, the underlying rustc command remains unaware of this --color option, so it fully relies on its checks (mentioned above) that fail to recognise the IntelliJ command output window as suitable for colored output. And here we are, with the red stderr text.