Stuck on an issue?

Lightrun Answers was designed to reduce the constant googling that comes with debugging 3rd party libraries. It collects links to all the places you might be looking at while hunting down a tough bug.

And, if you’re still stuck at the end, we’re happy to hop on a call to see how we can help out.

Improve recovery of items within blocks

See original GitHub issue

fn main() {
    trait Foo {
        intellijidearulezz
    }
}

Has pretty poor recovery, PSI:

FILE(0,62)
  RustFnItemElementImpl(FN_ITEM)(0,60)
    PsiElement(fn)('fn')(0,2)
    PsiWhiteSpace(' ')(2,3)
    PsiElement(<IDENTIFIER>)('main')(3,7)
    RustParametersElementImpl(PARAMETERS)(7,9)
      PsiElement(()('(')(7,8)
      PsiElement())(')')(8,9)
    PsiWhiteSpace(' ')(9,10)
    RustBlockElementImpl(BLOCK)(10,60)
      PsiElement({)('{')(10,11)
      PsiWhiteSpace('\n    ')(11,16)
      RustTraitItemElementImpl(TRAIT_ITEM)(16,27)
        PsiElement(trait)('trait')(16,21)
        PsiWhiteSpace(' ')(21,22)
        PsiElement(<IDENTIFIER>)('Foo')(22,25)
        PsiWhiteSpace(' ')(25,26)
        RustTraitBodyElementImpl(TRAIT_BODY)(26,27)
          PsiElement({)('{')(26,27)
          PsiErrorElement:fn or '}' expected, got 'intellijidearulezz'(27,27)
            <empty list>
      PsiWhiteSpace('\n        ')(27,36)
      RustPathExprElementImpl(PATH_EXPR)(36,54)
        RustPathElementImpl(PATH)(36,54)
          PsiElement(<IDENTIFIER>)('intellijidearulezz')(36,54)
      PsiWhiteSpace('\n    ')(54,59)
      PsiElement(})('}')(59,60)
  PsiWhiteSpace('\n')(60,61)
  PsiErrorElement:const, enum, extern, fn, impl, mod, static, struct, trait, type or use expected, got '}'(61,62)
    PsiElement(})('}')(61,62)

I think even dumb seeking for closing brace should yield nicer AST.

Issue Analytics

State:
Created 7 years ago
Comments:6 (6 by maintainers)

Top GitHub Comments

1reaction

matkladcommented, Jul 28, 2016

Here’s how you do recovering in GK: https://github.com/intellij-rust/intellij-rust/commit/6d652f7c5852d02fe807c5176b42e78d8f498211

One thing to note is that recover_while fires even if the parse was successful (it should match zero tokens then)

0reactions

matkladcommented, Aug 1, 2016

Should be mostly covered by these commits:

https://github.com/intellij-rust/intellij-rust/commit/135e1a303908dc2534939b01dddbda3d7224336f https://github.com/intellij-rust/intellij-rust/commit/8b695976a1bad8cc0ea130a7c56f59ea7da0299e https://github.com/intellij-rust/intellij-rust/commit/e1c148ad0a67c05cfd59319692513d22d543032c

Hint at https://github.com/JetBrains/Grammar-Kit/issues/128#issuecomment-236204070 was instrumental.

Top Results From Across the Web

How to Recover All Broken Blocks In One Command in ...

The way to recover all broken blocks at once involves pasting some code into your browser's developer console. If you find it intimidating,...

19 Performing Block Media Recovery - Oracle Help Center

Use block media recovery to recover one or more corrupt data blocks within a data file. Block media recovery provides the following advantages...

Baseball Catcher Tips: How to Block and Recover with ...

The pitch should be in the dirt, forcing you to make the block, locate the ball, recover it quickly with your bare hand...

11 Tips for Better Blocks - Outpatient Surgery Magazine - AORN

Blocks can shorten recovery times, decrease post-op pain and nausea, and let patients regain awareness and mobility sooner than with general anesthesia.

Improve Your Cycling Performance with Block Training

By combining consecutively hard works with recovery, you can improve your cycling ... with block training and incorporate it into your workout planning....