Intentions to change `assert(a == b)` to `assert_eq(a, b)`

There are handy assert_eq, assert_ne macros in Rust. It would be nice to have inspections which would highlightassert!(a == b) and assert!(a != b) and suggest to change them into assert_eq(a, b) and assert_ne!(a, b).

A similar inspection is implemented here: https://github.com/intellij-rust/intellij-rust/blob/master/src/main/kotlin/org/rust/ide/inspections/RsSimplifyPrintInspection.kt

A complete example of adding new inspections is here: https://github.com/intellij-rust/intellij-rust/commit/df64cbac9b6d14413bd15f3e33971ea725108a1e#diff-5e7848624647a9a96dd649e15fa64ae5

[mkaput]

At the moment, assert_eq! gives a better error message, so I think we should flip the direction of the intention once the RFC is implemented and is stable. If one does not want better messages, now, one can disable the inspection 😃

Note that our plugin is often used by beginner rustaceans, and so this intention might encourage them to use pattern which soon will be deprecated.

[robinst]

Note that recently an RFC was accepted that makes assert!(a == b) the preferred form in the future: RFC 2011 Nicer assert messages

So I would consider undoing the warning about using assert!, to not make people switch to assert_eq! and then back when the better assert! is implemented.